Repository navigation
Conversation
expand_filepath() resolves the last component of the link path, so when it is an existing dangling symlink, the new link is created at its target instead of failing. The same applies to link(). Resolve only the directory part and keep the last component as given so the kernel reports EEXIST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21992.
expand_filepath()resolves the last component of the link path, so when it is an existing dangling symlink, the new link is silently created at the symlink target andsymlink()returnstrue.link()has the same problem.This resolves only the directory part of the link path and keeps the last component as given, so the kernel reports
EEXISTfor any existing entry (including a dangling symlink) and the usual "File exists" warning is emitted. No extra pre-check is needed, so there is no race between the check and the link creation.Supersedes #22024, which added an
lstat/statpre-check instead of fixing the path resolution and did not coverlink().