Repository navigation
Conversation
Skip the duplicate and merge when either operand is empty, unless sharing would change the internal pointer or next free index.
Member
Author
|
Some numbers, release build without opcache, best of 7 runs, in ms. 8 elements, 1M iterations:
100 elements, 100k iterations:
|
devnexen
marked this pull request as ready for review
October 10, 2026 20:20
ndossche
reviewed
Oct 11, 2026
| /* $a += $a */ | ||
| return; | ||
| } | ||
| if (zend_hash_num_elements(Z_ARRVAL_P(op2)) == 0 && |
Member
There was a problem hiding this comment.
The conditions are unintuitive (talking about the entire nInternalPointer & free element conditions), can you add comments explaining them?
staabm
reviewed
Oct 11, 2026
Comment on lines
+1219
to
+1220
| src->nInternalPointer == 0 && | ||
| src->nNextFreeElement == next_free) { |
Contributor
There was a problem hiding this comment.
changed code uses a mix of tabs and spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the duplicate and merge when either operand is empty, unless sharing would change the internal pointer or next free index.