Repository navigation
Conversation
getopt() iterated $argv in place while converting each entry to a string, so a __toString() that modified or unset $argv could resize or free the hash under the iteration, which then read freed buckets. Hold a reference to the array for the duration of the loop so such writes separate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getopt() iterates $argv in place while converting each entry to a string, so a __toString() that modifies or unsets $argv resizes or frees the hash under the iteration; valgrind shows invalid reads in zif_getopt on 8.4. The array is now held for the duration of the loop, so such writes separate it, and the hold is released with GC_TRY_DTOR_NO_REF() so an unset $argv that is part of a cycle stays collectable. The long options array is passed by value, so it was already protected.