Repository navigation
Conversation
Collaborator
|
Review requested:
|
vmoroz
marked this pull request as draft
April 29, 2022 14:54
Member
Author
|
This PR is replaced with a PR in the node addon examples repo: nodejs/node-addon-examples#202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new test to show how to implement a native object as a Proxy object instead of
napi_define_class.The issue
V8 has
ObjectTemplatethat allows defining native objects as proxies.If native object has many methods, then
ObjectTemplatedoes not require to implement JavaScript property for each method.The Node.js NAN uses
ObjectTemplateto define native objects.Since Node API does not have such API, it creates issues when we convert code from NAN to Node API.
See: nodejs/node-addon-api#1114
Solution
We discussed this issue with the Node API team.
Since we want the Node API to work with all JavaScript engines, we want to see if we can achieve the same results without adding new APIs.
In this PR I have created a new Node API unit test that shows how to use JavaScript
Proxyto simulate some behavior ofObjectTemplateusing existing Node API.TODO
Proxybehavior