Skip to content

test-debug-port-cluster or test-debug-signal-cluster hanging in background on freebsd #6989

Closed
Closed
test-debug-port-cluster or test-debug-signal-cluster hanging in background on freebsd#6989
Labels
clusterIssues and PRs related to the cluster subsystem.freebsdIssues and PRs related to the FreeBSD platform.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@rvagg
rvagg
opened on May 26, 2016

found ~550 (not a typo) instances of test/fixtures/clustered-server/app.js running on one of the freebsd CI machines, this is used by both test-debug-port-cluster and test-debug-signal-cluster and I'm not sure which one was parent. Typical entries look like:

iojs          11971   0.0  0.2  620776  3556  -  I    16May16      0:00.09 /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/node --debug=13683 /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/fixtures/clustered-server/app.js

@nodejs/testing

Activity

  1. Trott commented on May 26, 2016

    @Trott
    Trott
    on May 26, 2016
    Member

    Not sure I have a fully coherentl explanation as to how this could plausibly cause the issue but the +1000 in this line seems like a code smell to me. Ought to just be common.PORT. Will submit a PR momentarily...

  2. Trott
    added a commit that references this issue on May 26, 2016

    test: remove modifcation to common.PORT

    46ae822
  3. mscdex
    added
    clusterIssues and PRs related to the cluster subsystem.
    debugger
    testIssues and PRs related to Node.js core tests and test infrastructure.
    freebsdIssues and PRs related to the FreeBSD platform.
    on May 26, 2016

  4. cjihrig commented on May 26, 2016

    @cjihrig
    cjihrig
    on May 26, 2016
    Contributor

    Could we build something into the CI or test runner to 1) detect tests that leave orphans running. 2) log that information somewhere. 3) kill the orphans.

  5. Trott commented on May 26, 2016

    @Trott
    Trott
    on May 26, 2016
    Member

    @cjihrig I imagine the main challenge would be distinguishing between orphans and other tests that are running in parallel.

  6. cjihrig commented on May 26, 2016

    @cjihrig
    cjihrig
    on May 26, 2016
    Contributor

    From a little Googling, it seems like identifying orphans is possible. I just don't know that we could associate that back to individual tests.

  7. Trott
    added a commit that references this issue on May 29, 2016

    test: remove modifcation to common.PORT

    bddfe63
  8. Fishrock123
    added a commit that references this issue on May 30, 2016

    test: remove modifcation to common.PORT

    4e826f4
  9. rvagg
    added a commit that references this issue on Jun 2, 2016

    test: remove modifcation to common.PORT

    0a258e5

  10. cjihrig commented on Jun 2, 2016

    @cjihrig
    cjihrig
    on Jun 2, 2016
    Contributor

    @Trott can this be closed?

  11. Trott commented on Jun 2, 2016

    @Trott
    Trott
    on Jun 2, 2016
    Member

    Yes. Closing.

  12. Trott
    closed this as completedon Jun 2, 2016
  13. MylesBorins
    added 5 commits that reference this issue on Jul 11, 2016

    test: remove modifcation to common.PORT

    182a609

    test: remove modifcation to common.PORT

    ed586ec

    test: remove modifcation to common.PORT

    cd99a3e

    test: remove modifcation to common.PORT

    58a3852

    test: remove modifcation to common.PORT

    cde3014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    clusterIssues and PRs related to the cluster subsystem.freebsdIssues and PRs related to the FreeBSD platform.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions