Skip to content

std::shared_ptr<T>::unique was removed in C++20 #47311

Closed
Closed
std::shared_ptr<T>::unique was removed in C++20#47311
Labels
c++Issues and PRs that require attention from people who are familiar with C++.

Description

@targos
targos
opened on Mar 30, 2023

Code:

node/src/node_threadsafe_cow-inl.h

Line 10 in 67660e8

if (!data_.unique()) {

Found in: #45427 (comment)

Refs: https://en.cppreference.com/w/cpp/memory/shared_ptr/unique

@nodejs/cpp-reviewers

Activity

  1. targos
    added
    c++Issues and PRs that require attention from people who are familiar with C++.
    on Mar 30, 2023

  2. gengjiawen commented on Mar 30, 2023

    @gengjiawen
    gengjiawen
    on Mar 30, 2023 · Hidden as outdated

  3. RaisinTen commented on Mar 30, 2023

    @RaisinTen
    RaisinTen
    on Mar 30, 2023
    Member

    I think #47315 might fix this.

  4. RaisinTen
    added a commit that references this issue on Mar 30, 2023

    src: remove usage of `std::shared_ptr<T>::unique()`

    409158a

  5. gengjiawen commented on Mar 31, 2023

    @gengjiawen
    gengjiawen
    on Mar 31, 2023
    Member

    I tested #47315 on VS2022, it works.

  6. RaisinTen
    closed this as completedin 1ff9824on Apr 5, 2023
  7. danielleadams
    added a commit that references this issue on Jul 6, 2023

    src: remove usage of `std::shared_ptr<T>::unique()`

    f7b6e5b
  8. MoLow
    added a commit that references this issue on Jul 6, 2023

    src: remove usage of `std::shared_ptr<T>::unique()`

    ded4a5e
  9. MayaLekova
    added a commit that references this issue on May 22, 2026

    src: remove usage of `std::shared_ptr<T>::unique()`

    1ff9824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions