Skip to content

python tools/test.py -J --mode=release parallel/test-* #44330

Closed
Closed
python tools/test.py -J --mode=release parallel/test-*#44330
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Description

@ronag
ronag
opened on Aug 21, 2022

python tools/test.py -J --mode=release parallel/test-* doesn't seem to work anymore?

node$ python tools/test.py -J --mode=release parallel/test-*
  File "tools/test.py", line 230
    print(f" failed {len([i for i in outputs if i.UnexpectedOutput()]) + 1} out of {self.measure_flakiness + 1}")

Activity

  1. ronag commented on Aug 21, 2022

    @ronag
    ronag
    on Aug 21, 2022
    MemberAuthor

    @Trott

  2. MoLow commented on Aug 21, 2022

    @MoLow
    MoLow
    on Aug 21, 2022
    Member

    I had to upgrade my python version for it to work properly.
    What version are you using?

  3. MoLow
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    toolsIssues and PRs related to the tools directory.
    and removed
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Aug 21, 2022

  4. ronag commented on Aug 21, 2022

    @ronag
    ronag
    on Aug 21, 2022
    MemberAuthor

    2.7

  5. MoLow commented on Aug 21, 2022

    @MoLow
    MoLow
    on Aug 21, 2022
    Member

    I think #43954 made tools/test.py work only on python 3
    @ronag can you confirm by running python3 tools/test.py -J --mode=release parallel/test-*?

  6. MoLow commented on Aug 21, 2022

    @MoLow
    MoLow
    on Aug 21, 2022
    Member

    NVM, I reproduced locally:

    python2 --version
Python 2.7.18

python2 tools/test.py -J message
  File "tools/test.py", line 230
    print(f" failed {len([i for i in outputs if i.UnexpectedOutput()]) + 1} out of {self.measure_flakiness + 1}")
                                                                                                               ^
SyntaxError: invalid syntax

    and

    python --version
Python 3.9.13

python tools/test.py -J message
[00:07|% 100|+  66|-   0]: Done

  7. MoLow commented on Aug 21, 2022

    @MoLow
    MoLow
    on Aug 21, 2022
    Member

    CC @aduh95
    I am not sure how important it is to support python 2

  8. ronag commented on Aug 21, 2022

    @ronag
    ronag
    on Aug 21, 2022
    MemberAuthor

    Thanks! That fixed it.

  9. ronag
    closed this as completedon Aug 21, 2022

  10. Trott commented on Aug 21, 2022

    @Trott
    Trott
    on Aug 21, 2022
    Member

    I am not sure how important it is to support python 2

    We dropped support for Python 2 some time ago. It has been EOL for a while. @nodejs/python might have more context to supply (especially @cclauss).

  11. cclauss commented on Aug 21, 2022

    @cclauss
    cclauss
    on Aug 21, 2022
    Contributor

    Python 2 died 963 days ago on 1/1/2020. No security updates since then -- It should no longer be trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions