Buffer api error since 13.3.0 #31134

Activity

1. addaleax

   added

   node-apiIssues and PRs related to Node-API.Issues and PRs related to Node-API.

   on Dec 30, 2019
2. addaleax commented on Dec 30, 2019

   

   addaleax

   on Dec 30, 2019

   Member

   More actions

   @gengjiawen The errors on master and v13.x are very different.

   On v13.x, #30666 is probably the PR that exposed this bug.

   The master issue is related to the V8 ArrayBuffer BackingStore API changes, which are a breaking change for addons.

   👍React with 👍2Reacted by Jiawen Geng and Linz
3. addaleax

   self-assigned this

   on Dec 30, 2019
4. addaleax

   added a commit that references this issue on Dec 30, 2019

   n-api: keep napi_env alive while it has finalizers

   ...

   c109b3c
5. addaleax

   closed this as completedin 493faf6on Jan 4, 2020
6. gengjiawen commented on Jan 6, 2020

   

   gengjiawen

   on Jan 6, 2020

   MemberAuthor

   More actions

   The master issue is related to the V8 ArrayBuffer BackingStore API changes, which are a breaking change for addons.

   Is there any docs for developer to migrate this api in docs ?
7. targos

   added a commit that references this issue on Jan 6, 2020

   n-api: keep napi_env alive while it has finalizers

   ...

   d771221
8. targos

   added a commit that references this issue on Jan 14, 2020

   n-api: keep napi_env alive while it has finalizers

   ...

   b69f2dd
9. BethGriggs

   added a commit that references this issue on Feb 6, 2020

   n-api: keep napi_env alive while it has finalizers

   ...

   af5c489