Repository navigation
build: missing defenitions from headers tarball #23167
Description
- Version:
- Platform:
- Subsystem:
I did a semi-thorough grep for symbols our deps use to customise their build, and found a few. First one might have helped find #23122 earlier.
Question is, should we define them, and how (probably via common.gypi)?
- v8config.h
#if defined(V8_DEPRECATION_WARNINGS) && V8_HAS_ATTRIBUTE_DEPRECATED_MESSAGE
#if defined(V8_IMMINENT_DEPRECATION_WARNINGS) && \- zlib\zconf.h
#if defined(ZLIB_CONST) && !defined(z_const)
\include\node\openssl\zlib.h
#ifdef HAVE_UNISTD_H /* may be set to #if 1 by ./configure */
# define Z_HAVE_UNISTD_H
#endif
#ifdef HAVE_STDARG_H /* may be set to #if 1 by ./configure */
# define Z_HAVE_STDARG_H
#endif- openssl
# if defined(OPENSSL_NO_STDIO)
#if defined(OPENSSL_NO_ASM)
# if defined(OPENSSL_THREADS) && !defined(CRYPTO_TDEBUG)
# elif defined(OPENSSL_SYS_WINDOWS) && defined(OPENSSL_OPT_WINDLL)@nodejs/build-files
Activity
addaleax commentedon Sep 30, 2018
The zlib symbols should all be taken care of – we have
constavailable,HAVE_STDARG_His not used for the features we need in core, andZ_HAVE_UNISTD_His already set indeps/zlib/zlib.gyp.OPENSSL_NO_ASMis provided by our own configure script’s--openssl-no-asm.OPENSSL_THREADSsounds like something we don’t need because we already provide threadpool-based crypto functions.refack commentedon Sep 30, 2018
The problem I see is that our configuration and gyp files are not necessarily propogated to the headers tarball.
addaleax commentedon Sep 30, 2018
I’m not sure but I don’t think it’s an issue – the only thing that could potentially be defined is
OPENSSL_NO_ASM, but that shouldn’t affect ABI/API, so it’s okay to have diverging definitions (and probably doesn’t have any impact at all on addons)?build: add common `defines`