mips failures for parallel/test-buffer-write(float|double) #20336

Activity

1. kapouer commented on Apr 26, 2018

   

   kapouer

   on Apr 26, 2018

   ContributorAuthor

   More actions

   Other logs are available here. It is probably worth waiting the mipsel build before investigating.
2. kapouer commented on Apr 26, 2018

   

   kapouer

   on Apr 26, 2018

   ContributorAuthor

   More actions

   Two other tests fail on mips arch:
   sequential/test-performance
   parallel/test-cli-node-options

   (all failures related to eslint are because there's no eslint module around).
3. richardlau commented on Apr 27, 2018

   

   richardlau

   on Apr 27, 2018

   Member

   More actions

   (all failures related to eslint are because there's no eslint module around).

   Looks like we missed some tests in #18807.
4. richardlau

   added

   mipsIssues and PRs related to the MIPS architecture.Issues and PRs related to the MIPS architecture.

   on Apr 27, 2018
5. richardlau commented on Apr 27, 2018

   

   richardlau

   on Apr 27, 2018

   Member

   More actions

   #20372 should address the eslint failures.
6. BridgeAR commented on Apr 27, 2018

   

   BridgeAR

   on Apr 27, 2018

   Member

   More actions

   @kapouer would you be so kind and run this once for me on mips and show me the output:

   const buffer = Buffer.alloc(8);
   buffer.writeDoubleBE(NaN, 0);
   console.log(buffer);
7. kapouer commented on Apr 27, 2018

   

   kapouer

   on Apr 27, 2018

   ContributorAuthor

   More actions

   Unfortunately i can't run the code on the same server, i can have access only to that server. Where it results in (for both node 8.11 and 10.0):

   > const buffer = Buffer.alloc(8);
   undefined
   > buffer.writeDoubleBE(NaN, 0);
   8
   > console.log(buffer);
   <Buffer 7f f7 ff ff ff ff ff ff>
   
8. BridgeAR commented on Apr 27, 2018

   

   BridgeAR

   on Apr 27, 2018

   Member

   More actions

   @kapouer thanks a lot. Fix incoming.
9. BridgeAR commented on Apr 28, 2018

   

   BridgeAR

   on Apr 28, 2018

   Member

   More actions

   Now there is only the CLI test that should still fail. The question is what option it is that is not implemented. I guess it is --perf-prof. @kapouer would you mind checking that out?
10. kapouer commented on Apr 28, 2018

    

    kapouer

    on Apr 28, 2018

    ContributorAuthor

    More actions

    Sure ! Indeed --perf-prof breaks with

    node --perf-prof
    #
    # Fatal error in , line 0
    # unimplemented code
    #
    #
    #
    #FailureMessage Object: 0x7f97d284Trace/breakpoint trap
    
    
11. BridgeAR commented on Apr 28, 2018

    

    BridgeAR

    on Apr 28, 2018

    Member

    More actions

    @kapouer would you be so kind and test the tests with #20377 applied? All but the eslint tests should pass with that patch.
12. kapouer commented on Apr 28, 2018

    

    kapouer

    on Apr 28, 2018

    ContributorAuthor

    More actions

    @BridgeAR both failures (buffer NaN and --perf-prof) fail on mipsel too when testing with nodejs 8.11.
13. BridgeAR commented on Apr 28, 2018

    

    BridgeAR

    on Apr 28, 2018

    Member

    More actions

    With the NaN failures I guess you mean the value is represented as <Buffer 7f f7 ff ff ff ff ff ff>? That is expected and has something to do with mips and not with Node.js. We just have to fix the test again.
14. richardlau

    added a commit that references this issue on May 8, 2018

    tools: add eslint check for skipIfEslintMissing

    ...

    870ae72
15. richardlau commented on May 8, 2018

    

    richardlau

    on May 8, 2018

    Member

    More actions

    Failing tests addressed between #20372 and #20377.
16. richardlau

    closed this as completedon May 8, 2018
17. MylesBorins

    added 3 commits that reference this issue on May 8, 2018

    tools: add eslint check for skipIfEslintMissing

    ...

    aad2c23

    tools: add eslint check for skipIfEslintMissing

    ...

    f17a711

    tools: add eslint check for skipIfEslintMissing

    ...

    f7267b4