investigate flaky test-benchmark-child-process on Windows #12817

Activity

1. Trott

   added

   benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.Issues and PRs related to Node.js benchmarks and benchmarking infrastructure.

   child_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   on May 3, 2017
2. refack

   self-assigned this

   on May 4, 2017
3. refack commented on May 4, 2017

   

   refack

   on May 4, 2017

   Contributor

   More actions

   It's that [expletive] yes.exe again.

   👍React with 👍1Reacted by Rich Trott
4. refack

   added 2 commits that reference this issue on May 4, 2017

   test: fix flakyness with `yes.exe`

   ...

   7e8f7c7

   test: fix flakyness with `yes.exe`

   ...

   68c933c
5. refack

   closed this as completedin 68c933con May 6, 2017
6. refack commented on May 6, 2017

   

   refack

   on May 6, 2017

   Contributor

   More actions

   Post land stress: https://ci.nodejs.org/job/node-stress-single-test/1201/nodes=win-vs2015/
7. anchnk

   added a commit that references this issue on May 19, 2017

   test: fix flakyness with `yes.exe`

   ...

   ec83210
8. refack commented on Jun 4, 2017

   

   refack

   on Jun 4, 2017

   Contributor

   More actions

   Reopening:
   https://ci.nodejs.org/job/node-test-binary-windows/8986/RUN_SUBSET=2,VS_VERSION=vs2015,label=win2012r2/

   not ok 370 sequential/test-benchmark-child-process
     ---
     duration_ms: 0.623
     severity: fail
     stack: |-
       
       child_process\child-process-exec-stdout.js
       child_process\child-process-exec-stdout.js dur=0 len=1: 0
       ERROR: The process with PID 3816 (child process of PID 3692) could not be terminated.
       Reason: There is no running instance of the task.
       child_process.js:611
           throw err;
           ^
       
       Error: Command failed: taskkill /f /t /pid 3816
       ERROR: The process with PID 3816 (child process of PID 3692) could not be terminated.
       Reason: There is no running instance of the task.
       
       
           at checkExecSyncError (child_process.js:568:13)
           at Object.execSync (child_process.js:608:13)
           at Timeout._onTimeout (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vs2015\label\win2012r2\benchmark\child_process\child-process-exec-stdout.js:36:21)
           at ontimeout (timers.js:488:11)
           at tryOnTimeout (timers.js:323:5)
           at Timer.listOnTimeout (timers.js:283:5)
       assert.js:60
         throw new errors.AssertionError({
         ^
       
       AssertionError [ERR_ASSERTION]: 1 === 0
           at ChildProcess.child.on (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vs2015\label\win2012r2\test\sequential\test-benchmark-child-process.js:19:10)
           at emitTwo (events.js:125:13)
           at ChildProcess.emit (events.js:213:7)
           at Process.ChildProcess._handle.onexit (internal/child_process.js:197:12)
     ...
   
9. refack

   reopened this on Jun 4, 2017
10. bzoz commented on Jun 9, 2017

    

    bzoz

    on Jun 9, 2017

    Contributor

    More actions

    @refack, did #13457 solve this?
11. refack commented on Jun 9, 2017

    

    refack

    on Jun 9, 2017

    Contributor

    More actions

    @refack, did #13457 solve this?

    I think so.

    ---

    Fixed by #13457
12. refack

    closed this as completedon Jun 9, 2017
13. addaleax

    added a commit that references this issue on Jun 10, 2017

    test,benchmark: stabilize child-process

    ...

    216cb3f
14. gibfahn

    added a commit that references this issue on Jun 20, 2017

    test: fix flakyness with `yes.exe`

    ...

    7fc0946
15. MylesBorins

    added a commit that references this issue on Jul 11, 2017

    test: fix flakyness with `yes.exe`

    ...

    739c579
16. refack

    removed their assignment

    on Oct 24, 2018