Repository navigation
get-metadata: missing 'LGTM' in comments #166
Description
Command: winpty get-metadata.cmd 18630 --check-comments
Output:
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/18630
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
--------------------------------------------------------------------------------Missing: nodejs/node#18630 (comment)
Activity
priyank-p commentedon Feb 8, 2018
@vsemozhetbyt just want to confirm did the
get-metadataoutput had something that saidmaclover7 approved via LGTM in commentor something along those lines? since this is all we do currently and it's not included in generated metadata.vsemozhetbyt commentedon Feb 8, 2018
@cPhost
Full output:
priyank-p commentedon Feb 8, 2018
Ok thanks, this is a bug.
joyeecheung commentedon Feb 8, 2018
I think we have already discussed about this. This is by design - only comments that contain nothing but LGTM will get a warning, other types of comments don't get anything at all, because there will always be "something LGTM but I am not the expert in other things", or "I cannot give a LGTM for this" or "I would want @ someone 's LGTM for this " or other types of thing that don't make them legitimate sign-offs. In the end we will have to resort to natural language processing.
joyeecheung commentedon Feb 8, 2018
BTW in those cases, something like #140 would be more suitable because without NLP code, humans are better at deciding if a comment with "LGTM" is legitimate sign-off
priyank-p commentedon Feb 8, 2018
Oh, okay it does make sense now, so this is not a bug. I glanced at the PR again quickly to get some idea all i got was we don't include in metadata which i already knew, and something that said
<name>(<username>) approved via LGTM in comment)😅.github-actions commentedon Aug 17, 2020
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
codebytere commentedon Aug 18, 2020
Gonna close this one since it's pretty old and i don't think this is something there's wide interest in doing but please reopen if that's not the case!