Repository navigation
threadsafe_function test - CI failing on Master since May 4th #994
Description
Running test 'objectwrap_worker_thread'
Running test 'promise'
Running test 'reference'
Running test 'run_script'
Running test 'threadsafe_function/threadsafe_function'
FATAL ERROR: DataSourceThread Queue was never closing
Tests aborted with SIGSEGV
Build step 'Conditional steps (multiple)' marked build as failure
Sending e-mails to: michael_dawson@ca.ibm.com gabriel.schulhof@intel.com Arunesh.Chandra@microsoft.com
Collecting metadata...
Metadata collection done.
Notifying upstream projects of job completion
Finished: FAILURE
This seems to fail every time now.
@KevinEady I think you know the test best
@legendecas were there any changes in master that you think might have affected this?
Activity
mhdawson commentedon May 10, 2021
I wonder if this is related: #994
mhdawson commentedon May 10, 2021
There are no other changes that I can see which are tagged node-api around that time.
mhdawson commentedon May 10, 2021
@indutny FYI
legendecas commentedon May 10, 2021
nodejs/node@7abc7e4 (node-api: faster threadsafe_function) is landed on Node.js core around May 5th 1 AM (GMT). And there are no significant updates in node-addon-api since late April...
legendecas commentedon May 10, 2021
I can reproduce on local node.js main branch build. Will dig into the problem to seek a quick fix.
legendecas commentedon May 10, 2021
The failing test case is
test/threadsafe_function/threadsafe_function.js.legendecas commentedon May 10, 2021
Just found an assumption in the test about the execution timing of tsfn calls. Filed #995 trying to see if the quick fix works across various builds.
mhdawson commentedon May 11, 2021
Resolved in #995, @legendecas thanks.