Repository navigation
Unknown option 'rebase' error #1528
Description
Hello!
We have a project which uses GitPython to automate interacting with Git for GitOps based deployments. After the 3.1.30 release we started seeing an error in our integration tests:
failed on setup with "git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
cmdline: git pull -v -- origin --rebase
stderr: 'error: unknown option `rebase''"We believe it was introduced with this PR.
The code that is failing is:
repository = _initialize_repository(working_directory, remote_repository_url, token)
repository.remotes['origin'].pull('--rebase')Any help would be greatly appreciated!
Activity
stsewd commentedon Jan 3, 2023
Options should be passed as kwargs, the argument from pull() is a git reference (like a branch name).
haven't tested if this works
sgwilliams-ebsco commentedon Jan 3, 2023
Thanks for the quick response! We'll test out the
kwargsapproach and report back.sgwilliams-ebsco commentedon Jan 3, 2023
We've confirmed that
and
both work.
I wonder if this should have a been a bump to the major version since it changes the behavior of several of the core git methods. Admittedly, we were passing the options to the pull command incorrectly.
Anyway, our tests are passing again.
Thanks for the help!
Byron commentedon Jan 4, 2023
It's the trade-off between not causing surprises during automated upgrades and protecting unsuspecting uses of GitPython from harm. For critical fixes GitPython will typically choose a patch release even if these have the potential to break some users.