Repository navigation
Update "Using conditions to control job execution" Github Actions documentation - #44105
Conversation
Clarify usage of conditions in job execution and note limitations for shell conditions.
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
@mcummings128 Checking in with Actions about whether they think this is necessary or want to change any wording. |
|
@mcummings128 The Actions team doesn't want the documentation to discuss what can't be done in this article, but they did suggest linking to this article on expressions to better describe what can be done. I don't know if you want to do that in this PR, but it's an option if you don't mind changing what you've got. |
This comment was marked as spam.
This comment was marked as spam.
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
mchammer01
left a comment
There was a problem hiding this comment.
@mcummings128 👋🏻 - nice catch, this is a genuinely useful clarification! ✨
LGTM 🙌🏻
Just one tiny nit. Made a suggestion and will apply it before merging.
…run/control-jobs-with-conditions.md
mchammer01
left a comment
There was a problem hiding this comment.
Duh, thought I'd already approved this 😕
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Clarify usage of conditions in job execution and note limitations for shell conditions.
Why:
Closes: TBD
What's being changed (if available, include any code snippets, screenshots, or gifs):
The Github Actions documentation page "Using conditions to control job execution
" (see link below)
https://github.com/proxy/docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/control-jobs-with-conditions
Adds a small blurb that shell conditionals are not supported/evaluated in
jobs.<job_id>.if. While immediately obvious if trying to execute a workflow that does this, this should be stated explicitly. The phrase "You can use any supported context and expression to create a conditional." is not restrictive enough.Check off the following: