Skip to content

github/codeql-action/analyze should offer an output for the sarif path #1799

Closed
#1805
Closed
github/codeql-action/analyze should offer an output for the sarif path#1799
#1805
Labels
enhancementNew feature or requestgood first issueGood for newcomers

Description

@jsoref
jsoref
opened on Jul 25, 2023

There's an input for the output:

codeql-action/analyze/action.yml

Line 4 in 57a11be

inputs:

codeql-action/analyze/action.yml

Lines 8 to 11 in 57a11be

output:
description: The path of the directory in which to save the SARIF results
required: false
default: "../results"

But there is no output for the sarif file path:

codeql-action/analyze/action.yml

Lines 79 to 83 in 57a11be

outputs:
db-locations:
description: A map from language to absolute path for each database created by CodeQL.
sarif-id:
description: The ID of the uploaded SARIF file.

The output file defaults to ../results which isn't accepted by actions/upload-artifact:
https://github.com/jsoref/pdns/actions/runs/5657547911/job/15326842548#step:12:4
https://github.com/jsoref/pdns/actions/runs/5657547911/job/15326842548#step:12:48

Run actions/upload-artifact@v3
  with:
    name: sarif
    path: ../results
    if-no-files-found: warn
...
Error: Invalid pattern '../results'. Relative pathing '.' and '..' is not allowed.

Activity

  1. aeisenberg
    added
    enhancementNew feature or request
    help wantedExtra attention is needed
    good first issueGood for newcomers
    and removed
    help wantedExtra attention is needed
    on Jul 25, 2023

  2. aeisenberg commented on Jul 25, 2023

    @aeisenberg
    aeisenberg
    on Jul 25, 2023
    Contributor

    That's interesting. Have you considered passing in a custom output value for the input to the analyze action and then using that value for upload artifact?

    I'm not sure if our team has capacity to look at this right now. However, we'd be willing to accept an external contribution for this.

  3. aeisenberg
    closed this as completedin #1805on Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions